Fixed a bug in the typescript definition and updated readme. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJWassink
force-pushed
the
change/typescript-fixes-and-readme-update
branch
from
b03841d to
61cfff3
Compare
DJWassink
force-pushed
the
change/typescript-fixes-and-readme-update
branch
from
61cfff3 to
59ae1df
Compare
nettofarah
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buch of small different changes in this PR.
I am not completely sure about including the
@types/validatorpackage withproperty-validator.It is required that it is preset in the dependencies instead of devDependencies because of: microsoft/types-publisher#81
Instead of this we could change the readme to tell users to install this package manually if they wan't the correct typings.
But I guess most users use it at the backend so this package isn't that much of a burden. And frontend devs properly don't even include the definitions anyway. Anyhow let me know what you think.